Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #222 - YAML support #224

Closed
wants to merge 15 commits into from
Closed

Issue #222 - YAML support #224

wants to merge 15 commits into from

Conversation

jackfreeman88
Copy link
Collaborator

  1. Compare experiments with visualize.py
  2. YAML file path assignment

@jackfreeman88 jackfreeman88 marked this pull request as draft August 7, 2024 02:54
@jackfreeman88 jackfreeman88 marked this pull request as ready for review August 7, 2024 02:55
@jackfreeman88 jackfreeman88 reopened this Aug 7, 2024
@andrewprzh
Copy link
Collaborator

Am I right that we actually need only this commit?
8ffa4a8

@andrewprzh
Copy link
Collaborator

This commit contains main file reformating, I would prefer not to modify it while there are a few dev branches

@jackfreeman88
Copy link
Collaborator Author

Ahh yes my my formatter, I shouldn't have even included the isoquant file in my commit!

@andrewprzh
Copy link
Collaborator

Thanks @jackfreeman88
Closing now in favor of cherry-picked commit

@andrewprzh andrewprzh closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewprzh andrewprzh Awaiting requested review from andrewprzh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackfreeman88 @andrewprzh