Explicitly specify workflow permissions required to succeed when our org switches default access from 'permissive' to 'restricted'
#441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll workflows. see: https://docs.github.com/en/actions/reference/authentication-in-a-workflow#permissions-for-the-github_token This is an experiment to explore what will break when we switch our org level default from 'permissive' to 'restricted'. see also: actions/upload-artifact#197 (comment)
They're not supported in the workflow syntax, yet they're referenced elsewhere in the docs in relation to the GITHUB_TOKEN, which is what confused me.
|
Somewhat opaque failure in the docs workflow:
Not unexpected, but the mission now is to work out what permission(s) is/are needed to fix that. That can contribute to the solution for ably/sdk-upload-action#29. |
Now that I know the docs workflow is working, I want to confirm my understanding (from the GitHub docs) that the entire set of permissions we define here will completely override the entire set of permissions set by default for the org. i.e. my expected outcome from this workflow in CI is for it to fail.
…maining satisfied when the org default moves from 'permissive' to 'restricted'.
QuintinWillison
changed the title
permissions required to succeed when our org switches default access from 'permissive' to 'restricted'
GitHub was happy to run the workflow with an unknown key alongside the step. Plus I hadn't read the docs properly (i.e. to acknowledge that permissions can be applied at workflow root or job level, but not at step level).
This was referenced Sep 18, 2021
owenpearson
approved these changes
Sep 20, 2021
KacperKluka
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request started out as an experiment (see initial commit message).
It has now matured to become a change we need to make to this repository in order to allow the docs workflow to continue functioning when our org default permissions scope changes from 'permissive' to 'restricted'. More on that in this internal Slack thread.