Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update presence message schema with corrected client type values #16

Merged
merged 1 commit into from
May 5, 2021
Merged

Update presence message schema with corrected client type values #16

merged 1 commit into from
May 5, 2021

Conversation

KacperKluka
Copy link
Contributor

Changed presence message schema client type values to be in the SCREAMING_SNAKE_CASE.

@KacperKluka KacperKluka self-assigned this Apr 29, 2021
@KacperKluka KacperKluka linked an issue Apr 29, 2021 that may be closed by this pull request
Change names of client type values from presence data #15
Closed
owenpearson
owenpearson approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@QuintinWillison QuintinWillison merged commit 017b146 into main May 5, 2021
@QuintinWillison QuintinWillison deleted the feature/update-presence-data-client-type branch May 5, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuintinWillison QuintinWillison QuintinWillison approved these changes

@owenpearson owenpearson owenpearson approved these changes

Assignees

@KacperKluka KacperKluka

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change names of client type values from presence data
3 participants
@KacperKluka @QuintinWillison @owenpearson