Asset class separate from Subscriber #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenpearson
force-pushed
the
asset-class
branch
4 times, most recently
from
004bb9b to
ee73d5c
Compare
owenpearson
changed the title
owenpearson
force-pushed
the
asset-class
branch
from
ee73d5c to
6e6f4c4
Compare
owenpearson
requested review from
KacperKluka,
QuintinWillison and
Peter-Maguire
QuintinWillison
suggested changes
Nov 11, 2022
owenpearson
force-pushed
the
asset-class
branch
from
6e6f4c4 to
871e6bf
Compare
KacperKluka
suggested changes
Nov 14, 2022
owenpearson
force-pushed
the
asset-class
branch
from
871e6bf to
5b3dcb4
Compare
QuintinWillison
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #19, #99 , #108
I realise that the refactor commit here is excessively big, but it's not at all easy to break down, and I don't know if there even is a sensible way to do so. Feel free to suggest a different approach to the commit structure here. For reviewing the external facing changes in this PR the two subsequent commits (type declarations and readme) should give a complete picture of what's changed.