Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example app: add change resolution example #13

Merged
merged 5 commits into from
Jan 28, 2021
Merged

Example app: add change resolution example #13

merged 5 commits into from
Jan 28, 2021

Conversation

owenpearson
Copy link
Member

If merged, this PR will update the example app to request a different resolution depending on whether the map is zoomed in past a given threshold.

QuintinWillison
QuintinWillison suggested changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@QuintinWillison QuintinWillison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from return to await in a couple of lib implementation locations suggests that this PR also fixes a bug. Is that the case?

examples/subscribing-example-app/README.md Outdated Show resolved Hide resolved
Base automatically changed from feature/add-jest-unit-tests to main January 28, 2021 16:35
@QuintinWillison QuintinWillison merged commit 679ab7d into main Jan 28, 2021
@QuintinWillison QuintinWillison deleted the feature/add-change-resolution-example branch January 28, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paddybyers paddybyers paddybyers left review comments

@QuintinWillison QuintinWillison QuintinWillison approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@owenpearson @paddybyers @QuintinWillison