use new enum encoding for client type #36
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@owenpearson as I've written in the issue #34 merging this will break the compatibility with Android and iOS apps because those changes are not present there 😉 So I don't think that we should land this PR at the moment 😉 |
|
@KacperKluka What should be the trigger to enable this PR to land? |
|
@QuintinWillison Ideally both Android and iOS issues should be closed together with this JS issue. Otherwise, the mobile SDKs will |
|
Android PR is ready ably/ably-asset-tracking-android#310 so we can progress with this PR too 😁 |
QuintinWillison
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved #34.