Add mapbox demo #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only allow one vehicle at a time
|
@QuintinWillison or @paddybyers if either of you is ok with this - lets merge this |
QuintinWillison
approved these changes
Dec 11, 2020
|
What's with the target branch? We only have one PR open. 🤔 |
|
Good question about the target branch. |
|
@kavalerov feature/asset-subscriber has already been pulled into main so if I'm not mistaken this should go into main when we're ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 2: Adds a modified version of the private ably-mapbox-demo web example, albeit without the capability of showing multiple drivers at once. Map provider API keys are now loaded into HTML script tags from a local .env file using EJS template engine (and old API keys have been purged from the commit history using bfg repo cleaner).