Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcasting of requested resolution #8

Merged
merged 8 commits into from
Jan 8, 2021
Prev Previous commit
Next Next commit
use promises for resolution change requests
  • Loading branch information
owenpearson committed Jan 7, 2021
commit 4a06271263f98fe7ed707c2f17d51c55ce5e4df1
19 changes: 5 additions & 14 deletions src/lib/AssetConnection.ts
Original file line number Diff line number Diff line change
@@ -56,20 +56,11 @@ class AssetConnection {
this.ably.close();
};

performChangeResolution = async (
resolution: Resolution,
onSuccess: () => unknown,
onError: (err: Error) => unknown
): Promise<void> => {
try {
await this.channel.presence.update({
type: ClientTypes.subscriber,
resolution,
});
nextTick(() => onSuccess());
} catch (e) {
nextTick(() => onError(e));
}
performChangeResolution = async (resolution: Resolution): Promise<void> => {
return this.channel.presence.update({
type: ClientTypes.publisher,
resolution,
});
};

private subscribeForRawEvents = (rawLocationListener: LocationListener) => {
9 changes: 4 additions & 5 deletions src/lib/AssetSubscriber.ts
Original file line number Diff line number Diff line change
@@ -2,7 +2,6 @@ import { Types as AblyTypes } from 'ably';
import { LocationListener, Resolution, StatusListener } from '../types';
import AssetConnection from './AssetConnection';
import Logger, { LoggerOptions } from './utils/Logger';
import { nextTick } from './utils/utils';

export type SubscriberOptions = {
ablyOptions: AblyTypes.ClientOptions;
@@ -43,14 +42,14 @@ class AssetSubscriber {
);
}

sendChangeRequest(resolution: Resolution, onSuccess: () => unknown, onError: (err: Error) => unknown): void {
sendChangeRequest = async (resolution: Resolution): Promise<void> => {
this.resolution = resolution;
if (!this.assetConnection) {
nextTick(() => onError(new Error('Cannot change resolution; no asset is currently being tracked.')));
throw new Error('Cannot change resolution; no asset is currently being tracked.');
} else {
this.assetConnection.performChangeResolution(resolution, onSuccess, onError);
return this.assetConnection.performChangeResolution(resolution);
}
}
};

stop = async (): Promise<void> => {
await this.assetConnection?.close?.();