Skip to content

Commit

Permalink
[ECO-5196] Updated Metadata.kt, refactored Metadata type to JsonObject
Browse files Browse the repository at this point in the history
- Updated usages across roomreactions, messages and chatAPI to use JsonObject
  • Loading branch information
sacOO7 committed Feb 4, 2025
1 parent 71b20c4 commit 8cf8d51
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion chat-android/src/main/java/com/ably/chat/ChatApi.kt
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ internal class ChatApi(
roomId = it.requireString("roomId"),
text = it.requireString("text"),
createdAt = it.requireLong("createdAt"),
metadata = it.asJsonObject.get("metadata"),
metadata = it.asJsonObject.getAsJsonObject("metadata"),
headers = it.asJsonObject.get("headers")?.toMap() ?: mapOf(),
action = action,
)
Expand Down
2 changes: 1 addition & 1 deletion chat-android/src/main/java/com/ably/chat/Messages.kt
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,6 @@ private fun parsePubSubMessageData(data: Any): PubSubMessageData {
}
return PubSubMessageData(
text = data.requireString("text"),
metadata = data.get("metadata"),
metadata = data.getAsJsonObject("metadata"),
)
}
4 changes: 2 additions & 2 deletions chat-android/src/main/java/com/ably/chat/Metadata.kt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.ably.chat

import com.google.gson.JsonElement
import com.google.gson.JsonObject

/**
* Metadata is a map of extra information that can be attached to chat
Expand All @@ -15,4 +15,4 @@ import com.google.gson.JsonElement
* The key `ably-chat` is reserved and cannot be used. Ably may populate
* this with different values in the future.
*/
typealias Metadata = JsonElement
typealias Metadata = JsonObject
2 changes: 1 addition & 1 deletion chat-android/src/main/java/com/ably/chat/RoomReactions.kt
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ internal class DefaultRoomReactions(
type = data.requireString("type"),
createdAt = pubSubMessage.timestamp,
clientId = pubSubMessage.clientId,
metadata = data.get("metadata"),
metadata = data.getAsJsonObject("metadata"),
headers = pubSubMessage.extras?.asJsonObject()?.get("headers")?.toMap() ?: mapOf(),
isSelf = pubSubMessage.clientId == room.clientId,
)
Expand Down

0 comments on commit 8cf8d51

Please sign in to comment.