fix: SDK version in lib config

[ttypic]

Accidentally version in BuildConfig got additional quotes, and agent information in the channel options displayed incorrectly

Summary by CodeRabbit

• New Features

  • Added a test to validate the app version configuration

• Bug Fixes

  • Corrected the app version build configuration to remove unnecessary quotation marks

[coderabbitai]

Walkthrough

The pull request focuses on refining the APP_VERSION configuration in the Android chat application's build process. The changes involve modifying the buildConfigField in the build.gradle.kts file to correctly define the version string without extra quotation marks. A corresponding test case has been added to verify that the version is correctly formatted, ensuring consistency in how the application version is represented during the build process.

Changes

File	Change Summary
chat-android/build.gradle.kts	Updated buildConfigField to use version.toString() instead of "\"${version}\""
chat-android/src/test/java/com/ably/chat/BuildConfigTest.kt	Added new test class to verify app version formatting

Possibly related PRs

• feat: add coverage checks with min 80% threshold #70: Changes to the Kover plugin in the same build.gradle.kts file related to build configuration

Suggested reviewers

• sacOO7

Poem

🐰 A version's tale, no quotes in sight,
Gradle's magic, now shining bright
Strings aligned with precision's grace
No extra marks to leave a trace
Build config sings a cleaner song! 🏗️

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bc01547 and 2870535.

📒 Files selected for processing (2)

• chat-android/build.gradle.kts (1 hunks)
• chat-android/src/test/java/com/ably/chat/BuildConfigTest.kt (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• chat-android/src/test/java/com/ably/chat/BuildConfigTest.kt
• chat-android/build.gradle.kts

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: check
• GitHub Check: coverage

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[AndyTWF]

Could do this with a RexExp to avoid having to update the test on every release, but not too fussed here

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

chat-android/src/test/java/com/ably/chat/BuildConfigTest.kt (1)

8-11: Consider reading version from gradle.properties instead of hardcoding.

The hardcoded version "0.1.0" will require manual updates during releases. Consider reading the version from gradle.properties to ensure consistency and reduce maintenance overhead.

Here's how you can modify the test:

-    fun `should hold app version without extra quotes`() {
-        assertEquals("0.1.0", BuildConfig.APP_VERSION)
+    fun `should hold app version without extra quotes`() {
+        val expectedVersion = Properties().apply {
+            load(File("../gradle.properties").inputStream())
+        }.getProperty("VERSION_NAME")
+        assertEquals(expectedVersion, BuildConfig.APP_VERSION)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a791f6 and bc01547.

📒 Files selected for processing (3)

• CONTRIBUTING.md (1 hunks)
• chat-android/build.gradle.kts (1 hunks)
• chat-android/src/test/java/com/ably/chat/BuildConfigTest.kt (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: coverage
• GitHub Check: check

🔇 Additional comments (2)

chat-android/build.gradle.kts (1)

49-49: LGTM! Fix for extra quotes in version string.

The change correctly removes the extra quotes from the version string by using toString() instead of string interpolation with quotes.

CONTRIBUTING.md (1)

134-135: Note: This step might need revision if BuildConfigTest is updated.

If the suggestion to read the version from gradle.properties in BuildConfigTest is implemented, this step would no longer be necessary as the test would automatically use the updated version.

[github-actions]

Code Coverage

Total Project Coverage	85.88%	✅