Fix Presence.get(…) signature

[lawrence-forooghian]

Mistake in 20e7f5f.

Summary by CodeRabbit

• New Features

  • Simplified retrieval of presence data by updating the get() methods to return a straightforward array of presence members, enhancing user experience by making data access more intuitive.

• Bug Fixes

  • Resolved issues related to pagination handling in presence data retrieval, ensuring users receive the complete list of presence members without complications.

[coderabbitai]

Walkthrough

The changes in this pull request focus on the Presence protocol within the Sources/AblyChat/Presence.swift file. The main alteration involves the return types of the get() methods, which have transitioned from returning a paginated result type to a simple array of PresenceMember objects. This modification eliminates the pagination abstraction, allowing for straightforward retrieval of presence data while keeping other methods in the protocol unchanged.

Changes

File	Change Summary
Sources/AblyChat/Presence.swift	Modified get() and get(params:) methods to return [PresenceMember] instead of any PaginatedResult<[PresenceMember]>.

Poem

In the meadow where bunnies play,
The presence now comes in a simpler way.
No more pages to flip and to scroll,
Just a hop to the data, quick and whole!
With each member gathered, we cheer and we sway,
Hooray for the changes that brighten our day! 🐇✨

Tip

New review model

We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.

---

New features

Walkthrough comment now includes:

• Possibly related PRs: A list of potentially related PRs to help you recall past context.
• Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs. You can also provide custom labeling instructions in the UI or configuration file.

Notes:

• Please share any feedback in the discussion post on our Discord.
• Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 882224b and 28c606c.

Files selected for processing (1)

• Sources/AblyChat/Presence.swift (1 hunks)

Additional comments not posted (2)

Sources/AblyChat/Presence.swift (2)

7-7: LGTM!

The change to the get() method signature is approved. Removing the pagination abstraction and returning a simple array of PresenceMember objects simplifies the interface for retrieving presence data.

---

8-8: LGTM!

The change to the get(params:) method signature is approved. Removing the pagination abstraction and returning a simple array of PresenceMember objects simplifies the interface for retrieving presence data.