Merge pull request #1537 from ably/release/1.2.17

Release/1.2.17

CHANGELOG.md

@@ -1,5 +1,19 @@
 # Change Log
 
+## [1.2.17](https://github.com/ably/ably-cocoa/tree/1.2.17)
+
+[Full Changelog](https://github.com/ably/ably-cocoa/compare/1.2.16...1.2.17)
+
+**Fixed bugs:**
+
+- Ably `agents` client option is implemented incorrectly [\#1525](https://github.com/ably/ably-cocoa/issues/1525)
+
+**Closed issues:**
+
+- Implement API for fetching Agent identifier [\#1530](https://github.com/ably/ably-cocoa/issues/1530)
+- Fix error on trying to override `HTTPURLResponse._allHeaderFields` with Xcode 14 [\#1522](https://github.com/ably/ably-cocoa/issues/1522)
+- Replace usage of `SecKeychainItemDelete` to fix deprecation error in Xcode 14 [\#1521](https://github.com/ably/ably-cocoa/issues/1521)
+
 ## [1.2.16](https://github.com/ably/ably-cocoa/tree/1.2.16)
 
 [Full Changelog](https://github.com/ably/ably-cocoa/compare/1.2.15...1.2.16)

README.md

@@ -60,7 +60,7 @@ You can install Ably for iOS and macOS through Package Manager, CocoaPods, Carth
     - [This apple guide](https://developer.apple.com/documentation/swift_packages/adding_package_dependencies_to_your_app) explains the steps in more detail.
 - To install the `ably-cocoa` package in another **Swift Package**, then add the following to your `Package.Swift`:
 ```swift
- .package(url: "https://github.com/ably/ably-cocoa", from: "1.2.16"),
+ .package(url: "https://github.com/ably/ably-cocoa", from: "1.2.17"),
 ```
 ### Installing through [CocoaPods](https://cocoapods.org/)
 
@@ -103,7 +103,7 @@ If you see, for example, a `dyld: Library not loaded: @rpath/AblyDeltaCodec.fram
 
 ### Manual installation 
 
-1. Get the code from GitHub [from the release page](https://github.com/ably/ably-cocoa/releases/tag/1.2.16), or clone it to get the latest, unstable and possibly underdocumented version: `git clone git@github.com:ably/ably-cocoa.git`
+1. Get the code from GitHub [from the release page](https://github.com/ably/ably-cocoa/releases/tag/1.2.17), or clone it to get the latest, unstable and possibly underdocumented version: `git clone git@github.com:ably/ably-cocoa.git`
 2. Drag the directory `ably-cocoa/ably-cocoa` into your project as a group.
 3. Ably depends on our [MessagePack Fork](https://github.com/ably-forks/msgpack-objective-C) 0.2.0; get it [from the releases page](https://github.com/ably-forks/msgpack-objective-C/releases/tag/0.2.0-ably-1) and link it into your project.
 

Scripts/jazzy.sh

@@ -7,7 +7,7 @@ jazzy \
   --objc \
   --clean \
   --author Ably \
-  --module-version 1.2.16 \
+  --module-version 1.2.17 \
   --umbrella-header Source/Ably.h \
   --framework-root Source \
   --module Ably \

Source/ARTClientInformation.m

@@ -6,7 +6,7 @@
 #import <sys/utsname.h>
 
 NSString *const ARTClientInformationAgentNotVersioned = @"ARTClientInformationAgentNotVersioned";
-NSString *const ARTClientInformation_libraryVersion = @"1.2.16";
+NSString *const ARTClientInformation_libraryVersion = @"1.2.17";
 static NSString *const _libraryName = @"ably-cocoa";
 
 // NSOperatingSystemVersion has NSInteger as version components for some reason, so mitigate it here.

Spec/Tests/ARTDefaultTests.swift

@@ -6,6 +6,6 @@ class ARTDefaultTests: XCTestCase {
 
     func testVersions() {
         XCTAssertEqual(ARTDefault.apiVersion(), "1.2")
-        XCTAssertEqual(ARTDefault.libraryVersion(), "1.2.16")
+        XCTAssertEqual(ARTDefault.libraryVersion(), "1.2.17")
     }
 }

Spec/Tests/ClientInformationTests.swift

@@ -9,7 +9,7 @@ final class ClientInformationTests: XCTestCase {
 
         XCTAssertEqual(agents.keys.count, 2)
 
-        XCTAssertEqual(agents["ably-cocoa"], "1.2.16")
+        XCTAssertEqual(agents["ably-cocoa"], "1.2.17")
 
         #if os(iOS)
         XCTAssertTrue(agents.keys.contains("iOS"))
@@ -27,7 +27,7 @@ final class ClientInformationTests: XCTestCase {
     // CR3, CR3b
     func testAgentIdentifierWithAdditionalAgents_withNilAdditionalAgents() {
         let expectedIdentifier = [
-            "ably-cocoa/1.2.16",
+            "ably-cocoa/1.2.17",
             ARTDefault.platformAgent()
         ].sorted().joined(separator: " ")
 
@@ -42,7 +42,7 @@ final class ClientInformationTests: XCTestCase {
         ]
 
         let expectedIdentifier = [
-            "ably-cocoa/1.2.16",
+            "ably-cocoa/1.2.17",
             "demolib/0.0.1",
             "morelib",
             ARTDefault.platformAgent()

Spec/Tests/RealtimeClientConnectionTests.swift

@@ -378,7 +378,7 @@ class RealtimeClientConnectionTests: XCTestCase {
                     done()
                 case .connected:
                     if let transport = client.internal.transport as? TestProxyTransport, let query = transport.lastUrl?.query {
-                        expect(query).to(haveParam("agent", hasPrefix: "ably-cocoa/1.2.16"))
+                        expect(query).to(haveParam("agent", hasPrefix: "ably-cocoa/1.2.17"))
                     } else {
                         XCTFail("MockTransport isn't working")
                     }

Spec/Tests/RestClientTests.swift

@@ -1668,7 +1668,7 @@ class RestClientTests: XCTestCase {
                 let headerAgent = testHTTPExecutor.requests.first!.allHTTPHeaderFields?["Ably-Agent"]
                 let ablyAgent = ARTClientInformation.agentIdentifier(withAdditionalAgents: options.agents)
                 expect(headerAgent).to(equal(ablyAgent))
-                expect(headerAgent!.hasPrefix("ably-cocoa/1.2.16")).to(beTrue())
+                expect(headerAgent!.hasPrefix("ably-cocoa/1.2.17")).to(beTrue())
                 done()
             }
         }

Version.xcconfig

@@ -1 +1 @@
-CURRENT_PROJECT_VERSION = 1.2.16
+CURRENT_PROJECT_VERSION = 1.2.17