Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RealtimeChannel: channel subscribe messages is inconsistent with the API #183

Closed
ricardopereira opened this issue Feb 2, 2016 · 1 comment
Closed

RealtimeChannel: channel subscribe messages is inconsistent with the API #183

ricardopereira opened this issue Feb 2, 2016 · 1 comment
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@ricardopereira
Copy link
Contributor 

channel.subscribe { message, errorInfo in
}

channel.subscribeToName("Client 1") { message, errorInfo in
}
@ricardopereira ricardopereira added bug Something isn't working. It's clear that this does need to be fixed. realtime labels Feb 2, 2016
@ricardopereira ricardopereira mentioned this issue Feb 2, 2016
Merged
tcard added a commit that referenced this issue Feb 15, 2016
@tcard
Refactor channels to adjust to API spec.
97f0b16 
Using EventEmitter to emit state changes and messages.

Fixes #134, #183, #121, #189.
@tcard
Copy link
Contributor

tcard commented Feb 15, 2016

Fixed by 97f0b16.

@tcard tcard closed this as completed Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tcard @ricardopereira