Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring the code using transition: method. #1858

Closed
maratal opened this issue Jan 21, 2024 · 3 comments
Closed

Refactoring the code using transition: method. #1858

maratal opened this issue Jan 21, 2024 · 3 comments
Assignees
@maratal

Comments

@maratal
Copy link
Collaborator

maratal commented Jan 21, 2024 •
edited by sync-by-unito bot
Loading

Yeah, I would agree to get rid of transition: itself 👍 . I think it's always best to refactor the code when you have understanding of the code context.
I would let you decide on that part, provided this will be taken care of in the future : )
If a new dev takes a look at the current code, it will be very hard for them to understand it properly.

Originally posted by sacOO7 in #1714 (comment)

┆Issue is synchronized with this Jira Task by Unito
@sync-by-unito Sync by Unito
Copy link

sync-by-unito bot commented Jan 21, 2024

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-4043

@maratal maratal changed the title Refactor code that uses transition:. Consider research of refactoring the code using transition: method. Jan 21, 2024
@maratal maratal mentioned this issue Jan 21, 2024
Merged
@maratal
Copy link
Collaborator Author

maratal commented Jan 21, 2024

Related issue - #1856

@maratal maratal mentioned this issue Jan 28, 2024
Merged
@maratal maratal changed the title Consider research of refactoring the code using transition: method. Refactoring the code using transition: method. Jan 29, 2024
@maratal
Copy link
Collaborator Author

maratal commented Feb 23, 2024

see #1863

@maratal maratal closed this as completed Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maratal maratal

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maratal