[SDK-4043] transition: method refactoring
#1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1863/features
github-actions
bot
temporarily deployed
to
staging/pull/1863/jazzydoc
maratal
changed the title
transition: method refactoringtransition: method refactoring
sacOO7
requested changes
Jan 30, 2024
github-actions
bot
temporarily deployed
to
staging/pull/1863/features
maratal
changed the title
transition: method refactoringtransition: method refactoring
github-actions
bot
temporarily deployed
to
staging/pull/1863/jazzydoc
maratal
force-pushed
the
transition-refactoring
branch
from
d75c5c1 to
fea657b
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1863/features
github-actions
bot
temporarily deployed
to
staging/pull/1863/jazzydoc
maratal
changed the title
transition: method refactoringtransition: method refactoring
lawrence-forooghian
approved these changes
Feb 12, 2024
maratal
force-pushed
the
feature/no-connection-serial
branch
7 times, most recently
from
6e62c70 to
9618f95
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1863/features
github-actions
bot
temporarily deployed
to
staging/pull/1863/jazzydoc
maratal
force-pushed
the
transition-refactoring
branch
from
7acd692 to
e1ea275
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1863/features
github-actions
bot
temporarily deployed
to
staging/pull/1863/jazzydoc
…nd this is to reduce confusion when to call what and just call one transition on `CONNECTED` event. Test "test__013__Connection..." began to fail because it explicitly expects `errorReason` on conection to be nil, while RTN24 tells nothing about not setting this property (but RTN25 gives a specs list where the `Connection#errorReason` should be set which doesn't include RTN24 for some reason, but I think this is discussabe).
…`. Now `resumed` from metadata can be used directly since everything is inside one `transition:` method now.
…commit 66e5500 both calls to `connect` were generating `CONNECTING` event. After this change the second event is an `UPDATE`, and the first one is fired before listener subscribes to it (for that reason other tests using `once(.connecting)` also set `options.autoConnect` to false or control this process in some other way, like waiting for `CONNECTED` first or explicitly drop connection).
maratal
force-pushed
the
transition-refactoring
branch
from
e1ea275 to
77cc141
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1863/features
github-actions
bot
temporarily deployed
to
staging/pull/1863/jazzydoc
Also renamed `transition:` to `performTransitionToState` for realtime channel.
maratal
force-pushed
the
transition-refactoring
branch
from
77cc141 to
db461a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1858
This should be merged after #1714
Summary:
Now it's a single method for transition with more clear name and it passes
resumethrough metadata directly rather than in two steps (metadata->state change->method). Read commit messages for more.