Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test fails due to changed error message #1946

Closed
maratal opened this issue Jul 12, 2024 · 0 comments · Fixed by #1957
Closed

Test fails due to changed error message #1946

maratal opened this issue Jul 12, 2024 · 0 comments · Fixed by #1957
Assignees
@maratal
Labels
failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.

Comments

@maratal
Copy link
Collaborator

maratal commented Jul 12, 2024 •
edited
Loading

Some tests check for error message instead of an error code, so when error message changes test begins failing: "test__059__requestToken__ensure_that_the_message_is_rejected".

This is ubiquitous across test suite, not only in "test__059...".
@maratal maratal added the failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug. label Jul 12, 2024
@maratal maratal self-assigned this Jul 12, 2024
maratal added a commit that referenced this issue Jul 12, 2024
@maratal
Fix issue #1946 here so all tests would pass (the issue is too small …
84daa5d 
…to have a dedicated PR).
@maratal maratal mentioned this issue Jul 12, 2024
Merged
maratal added a commit that referenced this issue Jul 13, 2024
@maratal
Fix issue #1946 here so all tests would pass (the issue is too small …
0a70feb 
…to have a dedicated PR).
maratal added a commit that referenced this issue Jul 14, 2024
@maratal
Fix issue #1946 here so all tests would pass (the issue is too small …
ff1fbf6 
…to have a dedicated PR).
maratal added a commit that referenced this issue Jul 14, 2024
@maratal
Fix issue #1946 here so all tests would pass (the issue is too small …
61758e2 
…to have a dedicated PR).
@maratal maratal mentioned this issue Aug 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maratal maratal

Labels
failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ECO-4874] Replaced all occurences of checking error message ably/ably-cocoa
1 participant
@maratal