Fix 'queueMessages' expected behaviour #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardopereira
commented
Mar 26, 2020
ricardopereira
force-pushed
the
fix-1004
branch
2 times, most recently
from
46a54ba to
bc662e1
Compare
|
Breadcrumbs: internal discussion around failing tests which may be blocking @ricardopereira from fully testing this, which may be why this PR is still in Draft state. |
|
Yes, exactly. Thanks @QuintinWillison. |
ricardopereira
force-pushed
the
fix-1004
branch
from
bc662e1 to
40d1102
Compare
Publish and presence state changes should fail immediately if not in the connected state and shouldn't change the channel state.
Use the Realtime queue array for every message.
… connection state is INITIALIZED, CONNECTING or DISCONNECTED
ricardopereira
force-pushed
the
fix-1004
branch
from
b3ee004 to
d6b07d2
Compare
|
The CI is getting better but even so I had to restart some of them. |
|
@QuintinWillison BTW, this fixes #894 too 🙌 |
QuintinWillison
approved these changes
Apr 29, 2020
SimonWoolf
reviewed
Oct 19, 2022
| [channel setFailed:channelStatus]; | ||
| break; | ||
| default: | ||
| break; |
There was a problem hiding this comment.
Why is all of this still gated under a condition that fails if options.queueMessages is false? This is RTL3, right? That spec item doesn't mention anything about queueMessages, what do they have to do with each other?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1004