-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic APNS example #1319
Basic APNS example #1319
Conversation
Examples/AblyCocoaAPNSExample/AblyCocoaAPNSExample/AblyHelper.swift
Outdated
Show resolved
Hide resolved
@maratal not yet looked at the code, but my first observation is that we should probably also have a CI workflow that builds this example app? |
@maratal can you please add some instructions (perhaps a README in the app's directory) about how to use this app? I checked out the code, ran it on the simulator, clicked "Activate", and the first thing I got was a crash: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a very initial review for now - will review in more depth once I know how to use the app 😄
Examples/AblyCocoaAPNSExample/AblyCocoaAPNSExample.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
Examples/AblyCocoaAPNSExample/AblyCocoaAPNSExample/AblyHelper.swift
Outdated
Show resolved
Hide resolved
Examples/AblyCocoaAPNSExample/AblyCocoaAPNSExample/AblyHelper.swift
Outdated
Show resolved
Hide resolved
Examples/AblyCocoaAPNSExample/AblyCocoaAPNSExample/AblyHelper.swift
Outdated
Show resolved
Hide resolved
…swift Typo fix Co-authored-by: Lawrence Forooghian <53756884+lawrence-forooghian@users.noreply.github.com>
…swift typo fix Co-authored-by: Lawrence Forooghian <53756884+lawrence-forooghian@users.noreply.github.com>
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, might it be good to have the app's name be "Ably Push Example" instead of just "Push Example" so that developers know what it is when they see it / notifications from it on their device, and also to make it easier to search for?
Closes #1318
I kept the UI as basic as possible, because the focus of this example app is on the push notifications. Lets discuss more prettier UI if needed.