Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic APNS example #1319

Merged
merged 18 commits into from
Apr 14, 2022
Merged

Basic APNS example #1319

merged 18 commits into from
Apr 14, 2022

Conversation

maratal
Copy link
Collaborator

@maratal maratal commented Mar 27, 2022

Closes #1318

I kept the UI as basic as possible, because the focus of this example app is on the push notifications. Lets discuss more prettier UI if needed.

@maratal maratal changed the title Added files for basic APNS example Basic APNS example Mar 27, 2022
@lawrence-forooghian
Copy link
Collaborator

@maratal not yet looked at the code, but my first observation is that we should probably also have a CI workflow that builds this example app?

@lawrence-forooghian
Copy link
Collaborator

@maratal can you please add some instructions (perhaps a README in the app's directory) about how to use this app? I checked out the code, ran it on the simulator, clicked "Activate", and the first thing I got was a crash: Terminating app due to uncaught exception 'Invalid key', reason: '<YOUR ABLY API KEY> should be of the form <keyName>:<keySecret>'. I could, of course, go and investigate this crash, but I wouldn't expect a user of our SDK to need to do so.

Copy link
Collaborator

@lawrence-forooghian lawrence-forooghian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a very initial review for now - will review in more depth once I know how to use the app 😄

@maratal
Copy link
Collaborator Author

maratal commented Apr 3, 2022

we should probably also have a CI workflow that builds this example app

ba5c780

@maratal
Copy link
Collaborator Author

maratal commented Apr 3, 2022

can you please add some instructions (perhaps a README in the app's directory) about how to use this app?

db8de23

Copy link
Collaborator

@lawrence-forooghian lawrence-forooghian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, might it be good to have the app's name be "Ably Push Example" instead of just "Push Example" so that developers know what it is when they see it / notifications from it on their device, and also to make it easier to search for?

@maratal maratal merged commit f75f045 into main Apr 14, 2022
@maratal maratal deleted the feature/1318-basic-apns-example branch April 14, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Create simplified ably-cocoa example project for demonstrating push notifications capability
3 participants