Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation errors in Xcode 14.3 #1750

Merged
merged 2 commits into from
May 15, 2023
Merged

Fix compilation errors in Xcode 14.3 #1750

merged 2 commits into from
May 15, 2023

Conversation

lawrence-forooghian
Copy link
Collaborator

This makes the library buildable with Xcode 14.3.

Resolves #1591, resolves #1653.

@lawrence-forooghian
Fix C function compilation error in Xcode 14.3
a9da0e3 
The error was "A function declaration without a prototype is deprecated
in all versions of C".

Resolves #1591.
@lawrence-forooghian
Fix collection compilation error in Xcode 14.3
3f0307b 
The error was "Heterogeneous collection literal could only be inferred
to '[String : Any]'; add explicit type annotation if this is
intentional".

Resolves #1653.
@lawrence-forooghian lawrence-forooghian marked this pull request as ready for review May 15, 2023 13:50
@lawrence-forooghian lawrence-forooghian merged commit eff260a into main May 15, 2023
@lawrence-forooghian lawrence-forooghian deleted the xcode-14.3 branch May 15, 2023 16:58
lawrence-forooghian added a commit that referenced this pull request Oct 31, 2023
@lawrence-forooghian
Cherry-pick pull request #1750
316dad5 
`git cherry-pick -m1 eff260a`

Merge pull request #1750 from ably/xcode-14.3

Fix compilation errors in Xcode 14.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maratal maratal maratal approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run tests in Ably-iOS and Ably-macOS using Xcode 14.3 Compilation error in SocketRocket in Xcode 14.3
2 participants
@lawrence-forooghian @maratal