[SDK-3814] Refactoring for "test__023__Presence__Channel_state_change_side_effects…" #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts..." test. Now similar to https://github.com/ably/ably-js/blob/main/test/realtime/presence.test.js#L1908-L2043 it uses additional client to generate leave event (which makes sence).
github-actions
bot
temporarily deployed
to
staging/pull/1793/features
github-actions
bot
temporarily deployed
to
staging/pull/1793/jazzydoc
maratal
changed the title
There was a problem hiding this comment.
I agree that the motivation for the behaviour in the existing test is not very clear, and that it makes sense to replace it with something that makes more sense. However, I still think that the test, as it stands in this PR, is very difficult to understand (at least for me). What do you think?
github-actions
bot
temporarily deployed
to
staging/pull/1793/features
maratal
commented
Oct 11, 2023
github-actions
bot
temporarily deployed
to
staging/pull/1793/jazzydoc
…ed and re-attached events.
github-actions
bot
temporarily deployed
to
staging/pull/1793/features
github-actions
bot
temporarily deployed
to
staging/pull/1793/jazzydoc
lawrence-forooghian
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1792
Now a separate client is created for the member that will leave during SUSPENDED and ensure that a leave event for this member will be generated upon new attach.