[Experimental] Transition to Xcode 15 #1799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thout framework prefix.
…OBJC_CLASS_$_NSError". This `try/catch` block here is useless, just passing error further.
github-actions
bot
temporarily deployed
to
staging/pull/1799/features
maratal
changed the title
github-actions
bot
temporarily deployed
to
staging/pull/1799/jazzydoc
github-actions
bot
temporarily deployed
to
staging/pull/1799/features
github-actions
bot
temporarily deployed
to
staging/pull/1799/jazzydoc
github-actions
bot
temporarily deployed
to
staging/pull/1799/features
github-actions
bot
temporarily deployed
to
staging/pull/1799/jazzydoc
github-actions
bot
temporarily deployed
to
staging/pull/1799/features
github-actions
bot
temporarily deployed
to
staging/pull/1799/jazzydoc
maratal
changed the title
This was referenced Sep 15, 2023
…o-xcode15 # Conflicts: # .github/workflows/check-pod.yaml # .github/workflows/docs.yml # .github/workflows/integration-test-iOS16_4.yaml # .github/workflows/integration-test-macOS.yaml # .github/workflows/integration-test-tvOS16_4.yaml # Test/Tests/RealtimeClientChannelTests.swift
maratal
force-pushed
the
fix/1796-transition-to-xcode15
branch
from
1f9e3ae to
00133bd
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1799/features
github-actions
bot
temporarily deployed
to
staging/pull/1799/jazzydoc
maratal
force-pushed
the
fix/1796-transition-to-xcode15
branch
from
4699ea9 to
9882b13
Compare
maratal
force-pushed
the
fix/1796-transition-to-xcode15
branch
from
9882b13 to
74b5c1d
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1799/features
github-actions
bot
temporarily deployed
to
staging/pull/1799/jazzydoc
maratal
force-pushed
the
fix/1796-transition-to-xcode15
branch
from
74b5c1d to
24f5e21
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1799/features
github-actions
bot
temporarily deployed
to
staging/pull/1799/jazzydoc
maratal
force-pushed
the
fix/1796-transition-to-xcode15
branch
from
24f5e21 to
3a6ba31
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1799/features
github-actions
bot
temporarily deployed
to
staging/pull/1799/jazzydoc
github-actions
bot
temporarily deployed
to
staging/pull/1799/features
github-actions
bot
temporarily deployed
to
staging/pull/1799/jazzydoc
maratal
force-pushed
the
fix/1796-transition-to-xcode15
branch
from
f985ab8 to
a538c1e
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1799/features
Merged
…o-xcode15 # Conflicts: # Examples/AblyCarthage/AblyCarthage/AppDelegate.swift # Examples/AblyCarthage/AblyCarthage/Base.lproj/Main.storyboard # Examples/AblyCarthage/AblyCarthage/SceneDelegate.swift # Examples/AblyCarthage/AblyCarthage/ViewController.swift
maratal
force-pushed
the
fix/1796-transition-to-xcode15
branch
from
22d68be to
38475ad
Compare
…"new%20feature" in Foundation.
Test passes frequently because I assume tests failures after execution not always tracked by XCTest framework. Locally it crashes with this:
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Attempted to report a test failure to XCTest while no test case was running. The failure was:
"Completion closure should not be called"
In a test suite it goes as "test__092__RestClient__request__method_signature_and_arguments__should_do_a_request_and_receive_a_valid_response" failure (i.e. the test which is being executed at the moment when fail("Completion closure should not be called") is called (https://github.com/ably/ably-cocoa/blob/ca4ffa1f582714945b9f323a1dc86b1da57c974f/Test/Tests/RestClientTests.swift#L1916)).
maratal
added a commit
that referenced
this pull request
Nov 18, 2023
…_method_signature_and_arguments__should_do_a_request_and_receive_a_valid_response", i.e. the test which is being executed at the moment when fail("Completion closure should not be called") is called within "test__090__RestClient__..." test (https://github.com/ably/ably-cocoa/blob/ca4ffa1f582714945b9f323a1dc86b1da57c974f/Test/Tests/RestClientTests.swift#L1916).
Test passes frequently on CI because I assume tests failures after execution not always tracked by XCTest framework. Locally it crashes with this:
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Attempted to report a test failure to XCTest while no test case was running. The failure was:
"Completion closure should not be called".
The path "new feature" is not an invalid path, since it's being replaced with "new%20feature" in Foundation. So I'm removing this check.
I've noticed that this test fails frequently when other well known set of tests (https://test-observability.herokuapp.com/repos/ably/ably-cocoa/uploads/554d09f1-71e2-4e79-b641-9f33a8382220) don't fail. So when I've fixed it in this experimental PR (#1799), it finally could pass (after a few attemts).
maratal
added a commit
that referenced
this pull request
Nov 19, 2023
…_method_signature_and_arguments__should_do_a_request_and_receive_a_valid_response", i.e. the test which is being executed at the moment when fail("Completion closure should not be called") is called within "test__090__RestClient__..." test (https://github.com/ably/ably-cocoa/blob/ca4ffa1f582714945b9f323a1dc86b1da57c974f/Test/Tests/RestClientTests.swift#L1916).
Test passes frequently on CI because I assume tests failures after execution not always tracked by XCTest framework. Locally it crashes with this:
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Attempted to report a test failure to XCTest while no test case was running. The failure was:
"Completion closure should not be called".
The path "new feature" is not an invalid path, since it's being replaced with "new%20feature" in Foundation. So I'm removing this check.
I've noticed that this test fails frequently when other well known set of tests (https://test-observability.herokuapp.com/repos/ably/ably-cocoa/uploads/554d09f1-71e2-4e79-b641-9f33a8382220) don't fail. So when I've fixed it in this experimental PR (#1799), it finally could pass (after a few attemts).
|
Solved #1851 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1802