Code

[ECO-4695] Unskip presense tests#1907

Code

Merged

maratal merged 39 commits intomainably/ably-cocoa:mainfrom fix/1889-unskip-presense-testsably/ably-cocoa:fix/1889-unskip-presense-testsCopy head branch name to clipboardMay 13, 2024

+140-400

Commits

Commits on Apr 14, 2024

• Implement RTP18a (start of a new sync sequence and any previous in-flight sync is discarded).

  maratal

  committed
  2874779

  Copy full SHA for 2874779

Commits on Apr 18, 2024

• Merge remote-tracking branch 'origin/main' into fix/1904-RTP18a

  maratal

  committed
  f88cc2e

  Copy full SHA for f88cc2e

Commits on Apr 19, 2024

• Fixed shoudRestartSyncForSequenceId method name and updated test for RTP18a.

  maratal

  committed
  666906b

  Copy full SHA for 666906b

Commits on Apr 21, 2024

• Test has no sense, because RTP1 says "ProtocolMessage may contain a HAS_PRESENCE bit flag indicating that it will perform a presence sync". It doesn't say that without members it will omit HAS_PRES…

  Show description for 342d57a
  maratal

  committed
  342d57a

  Copy full SHA for 342d57a

• Improved commentary.

  maratal

  committed
  ee89bc5

  Copy full SHA for ee89bc5

• Fixed RTP18c test.

  maratal

  committed
  ec8df5c

  Copy full SHA for ec8df5c

• Fix test RTP19a - ensure incoming ATTACH message has no HAS_PRESENCE flag instead of requiring its absence (see RTP1).

  maratal

  committed
  150070f

  Copy full SHA for 150070f

Commits on Apr 26, 2024

• Fixed RTP2a test.

  maratal

  committed
  3011e00

  Copy full SHA for 3011e00

• Fixed RTP2g test.

  maratal

  committed
  243c074

  Copy full SHA for 243c074

• Fixed RTP2c test.

  maratal

  committed
  b132004

  Copy full SHA for b132004

• Removed unnecessary test for RTP2c (added additional check to the first RTP2c test). Also reduced number of members to decrease test duration which was also unnecessary long.

  maratal

  committed
  52c0a89

  Copy full SHA for 52c0a89

• More fixes for RTP2a test: subscribe to ENTER only, since realtime sends PRESENT there as well. Compare connections of two messages.

  maratal

  committed
  1232831

  Copy full SHA for 1232831

• Fix for RTP2d test - update only after enter is done.

  maratal

  committed
  02381fb

  Copy full SHA for 02381fb

• Removed unnecessary test for RTP2g (which is the same as for RTP2d for ENTER event).

  maratal

  committed
  dd4c7b5

  Copy full SHA for dd4c7b5

Commits on Apr 28, 2024

• Fix for RTP17 test - sometimes realtime sends PRESENT before ENTER and test fails.

  maratal

  committed
  e084f10

  Copy full SHA for e084f10

• Added forgotten dispose() call which unsubscribes channels. Without this clients remain in memory and interacts with later executing tests sometimes failing them, like here for example - https://te…

  Show description for 86e6ba2
  maratal

  committed
  86e6ba2

  Copy full SHA for 86e6ba2

• Removed broken FIXME link.

  maratal

  committed
  0f12e3e

  Copy full SHA for 0f12e3e

• Removed unnecessary startSync() call.

  maratal

  committed
  065583c

  Copy full SHA for 065583c

• Unskip tests that don't fail locally while being executed repeatedly (marked them FLAKY).

  maratal

  committed
  9ca4d6b

  Copy full SHA for 9ca4d6b

Commits on Apr 29, 2024

• Fixed RTP19 test (removed leave.clientId == internalMember.clientId assertion, bc realtime sometimes send LEAVE for other members too, not sure why it does that).

  maratal

  committed
  1998a84

  Copy full SHA for 1998a84

• Added forgotten resetting setListenerBeforeProcessingIncomingMessage call for transport. Might cause tests interfere with each other, like here f.e. - https://test-observability.herokuapp.com/repos…

  Show description for f169e1b
  maratal

  committed
  f169e1b

  Copy full SHA for f169e1b

Commits on Apr 30, 2024

• Realtime sends PRESENT among ENTER every other time and it fails test because decodeNumberOfCalls == 2 in such case.

  maratal

  committed
  85de5f5

  Copy full SHA for 85de5f5

• Removed FLAKY label since some of these tests seems to be failing not more than other tests and some not failing at all.

  maratal

  committed
  f73ae68

  Copy full SHA for f73ae68

• Added post-check of leave events received, since realtime might send those events for other members too.

  maratal

  committed
  1acc1a9

  Copy full SHA for 1acc1a9

• Realtime sometimes sends 50.

  maratal

  committed
  c71b546

  Copy full SHA for c71b546

• Spec RTP5b: "If a channel enters the ATTACHED state then all queued presence messages will be sent immediately. A presence SYNC may be initiated per RTP1".

  Show description for 3ed152d
  maratal

  committed
  3ed152d

  Copy full SHA for 3ed152d

Commits on May 2, 2024

• Merge remote-tracking branch 'origin/main' into fix/1889-unskip-presense-tests

  maratal

  committed
  da81ea1

  Copy full SHA for da81ea1

Commits on May 3, 2024

• Revert "Implement RTP18a (start of a new sync sequence and any previous in-flight sync is discarded)."

  Show description for 30d49a7
  maratal

  committed
  30d49a7

  Copy full SHA for 30d49a7

• Fixed RTP18b test.

  maratal

  committed
  7f7a466

  Copy full SHA for 7f7a466

Commits on May 5, 2024

• Ensure connections for this test are closed and completion closure only called in case of no errors. Otherwise it affects execution of the "test_111..." below - https://test-observability.herokuapp…

  Show description for dd75e84
  maratal

  committed
  dd75e84

  Copy full SHA for dd75e84

• Revert fix for RTP2a since it works bad either.

  maratal

  committed
  5460d1d

  Copy full SHA for 5460d1d

• New fix for RTP2a similar to 85de5f5.

  maratal

  committed
  83f3d92

  Copy full SHA for 83f3d92

• Ensure connections for this test are closed. Otherwise it affects execution of the "test__032..." below - https://test-observability.herokuapp.com/repos/ably/ably-cocoa/test_cases/ac44f09c-f521-4bf…

  Show description for 1de0538
  maratal

  committed
  1de0538

  Copy full SHA for 1de0538

Commits on May 6, 2024

• Removing "test__83" either, since it's from protocol v1. Currently upon disconnect internal presence map is kept and upon re-connect no synthesized LEAVE event appears to be sent by realtime.

  maratal

  committed
  0c149c4

  Copy full SHA for 0c149c4

• Removing "test__082.." since it's purpose is unclear, it claims in the title what is already done in test 080, but does cryptic things in its body. For example the comment

  Show description for 9b77978
  maratal

  committed
  9b77978

  Copy full SHA for 9b77978

Commits on May 7, 2024

• Another fix for RTP2a (ENTER/PRESENT ambiguity).

  maratal

  committed
  9dac73e

  Copy full SHA for 9dac73e

Commits on May 9, 2024

• Fixed test__080... and test__050... to properly check amount of members (syncInProgress vs not syncInProgress).

  maratal

  committed
  d0ee62c

  Copy full SHA for d0ee62c

• Removed extra attach, because according to RTL4i it happens after connection goes to CONNECTED (also it's called inside members get too). Also removed interception of a SYNC message, since it's n…

  Show description for 96eea55
  maratal

  committed
  96eea55

  Copy full SHA for 96eea55

• Fix queue to receive fake message.

  maratal

  committed
  c6fdeca

  Copy full SHA for c6fdeca