[ECO-4560] Removed pointless tests #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otivation of it isn't clear for me too, it tests queueing messages while connection state is DISCONNECTED and the channel is still ATTACHED, but according to RTL6c2 messages should be queued regardless channel state (except SUSPENDED or FAILED), which is already tested in "test__078__Channel..." and "test__077__Channel..."/"test__076__Channel..." for INITIALIZED and CONNECTING connection states respectively. The situation with `ttl` described in the issue #1798 isn't reproducable anymore.
…nnel..." test the same as "test__072__Channel..." and "test__074__Channel..." but with a token auth, which is unclear for me why it matters in these particular tests.
umair-ably
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1798