RTL7d

ablySpec/RealtimeClientChannel.swift

@@ -799,6 +799,65 @@ class RealtimeClientChannel: QuickSpec {
                     }
                 }
 
+                // RTL7d
+                pending("should deliver the message even if there is an error while decoding") {
+
+                    for cryptoTest in [CryptoTest.aes128, CryptoTest.aes256] {
+                        it("using \(cryptoTest) ") {
+                            let options = AblyTests.commonAppSetup()
+                            options.autoConnect = false
+                            let client = ARTRealtime(options: options)
+                            client.setTransportClass(TestProxyTransport.self)
+                            client.connect()
+                            defer { client.close() }
+
+                            let (keyData, ivData, messages) = AblyTests.loadCryptoTestData(cryptoTest)
+                            let testMessage = messages[0]
+
+                            let cipherParams = ARTCrypto.defaultParamsWithKey(keyData, iv: ivData)
+                            let channelOptions = ARTChannelOptions(encrypted: cipherParams)
+                            let channel = client.channels.get("test", options: channelOptions)
+
+                            let transport = client.transport as! TestProxyTransport
+
+                            transport.beforeProcessingSentMessage = { protocolMessage in
+                                if protocolMessage.action == .Message {
+                                    expect(protocolMessage.messages![0].data as? String).to(equal(testMessage.encrypted.data))
+                                    expect(protocolMessage.messages![0].encoding).to(equal(testMessage.encrypted.encoding))
+                                }
+                            }
+
+                            transport.beforeProcessingReceivedMessage = { protocolMessage in
+                                if protocolMessage.action == .Message {
+                                    expect(protocolMessage.messages![0].data as? String).to(equal(testMessage.encrypted.data))
+                                    expect(protocolMessage.messages![0].encoding).to(equal(testMessage.encrypted.encoding))
+                                    // Force an error decoding a message
+                                    protocolMessage.messages![0].encoding = "bad_encoding_type"
+                                }
+                            }
+
+                            waitUntil(timeout: testTimeout) { done in
+                                let logTime = NSDate()
+
+                                channel.subscribe(testMessage.encoded.name) { message in
+                                    expect(message.data as? String).to(equal(testMessage.encrypted.data))
+
+                                    let logs = querySyslog(forLogsAfter: logTime)
+                                    let line = logs.reduce("") { $0 + "; " + $1 } //Reduce in one line
+                                    expect(line).to(contain("ERROR: Failed to decode data as 'bad_encoding_type' encoding is unknown"))
+
+                                    expect(channel.errorReason!.message).to(contain("Failed to decode data as 'bad_encoding_type' encoding is unknown"))
+
+                                    done()
+                                }
+
+                                channel.publish(testMessage.encoded.name, data: testMessage.encoded.data)
+                            }
+                        }
+                    }
+
+                }
+
                 // RTL7f
                 it("should exist ensuring published messages are not echoed back to the subscriber when echoMessages is false") {
                     let options = AblyTests.commonAppSetup()

ablySpec/TestUtilities.swift

@@ -53,7 +53,6 @@ class AblyTests {
     class func checkError(errorInfo: ARTErrorInfo?) {
         checkError(errorInfo, withAlternative: "")
     }
-    static let allDebug = true
 
     class var jsonRestOptions: ARTClientOptions {
         get {
@@ -114,7 +113,7 @@ class AblyTests {
     class func clientOptions(debug debug: Bool = false, requestToken: Bool = false) -> ARTClientOptions {
         let options = ARTClientOptions()
         options.environment = "sandbox"
-        if debug || AblyTests.allDebug {
+        if debug {
             options.logLevel = .Debug
         }
         if requestToken {
@@ -454,6 +453,9 @@ class TestProxyTransport: ARTWebSocketTransport {
 
     private(set) var rawDataSent = [NSData]()
     private(set) var rawDataReceived = [NSData]()
+
+    var beforeProcessingSentMessage: Optional<(ARTProtocolMessage)->()> = nil
+    var beforeProcessingReceivedMessage: Optional<(ARTProtocolMessage)->()> = nil
 
     var actionsIgnored = [ARTProtocolMessageAction]()
 
@@ -465,6 +467,9 @@ class TestProxyTransport: ARTWebSocketTransport {
 
     override func send(msg: ARTProtocolMessage) {
         protocolMessagesSent.append(msg)
+        if let performEvent = beforeProcessingSentMessage {
+            performEvent(msg)
+        }
         super.send(msg)
     }
 
@@ -478,6 +483,9 @@ class TestProxyTransport: ARTWebSocketTransport {
         if actionsIgnored.contains(msg.action) {
             return
         }
+        if let performEvent = beforeProcessingReceivedMessage {
+            performEvent(msg)
+        }
         super.receive(msg)
     }