RTN15d #249
Merged
RTN15d #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardopereira
force-pushed
the
RTN15d
branch
from
d5bf275 to
f0b7614
Compare
|
I think this should be rebased with #228 fixes. |
| context("connection failures once CONNECTED") { | ||
|
|
||
| // RTN15d | ||
| pending("should recover from disconnection and messages delivered once the connection is resumed") { |
There was a problem hiding this comment.
Can we change this to "should recover from disconnection and publish queued messages once the connection is resumed"?
There was a problem hiding this comment.
Actually, I may have misread RTN15d and this suggested change is wrong. However, is this test then not the same as RTN15a, I'm not sure why there are two different tests?
Merged
ricardopereira
force-pushed
the
RTN15d
branch
from
f0b7614 to
7b8e8f5
Compare
|
Rebased with master with changes: 7b8e8f5. |
|
LGTM |
1 similar comment
|
LGTM |
ricardopereira
force-pushed
the
RTN15d
branch
from
7b8e8f5 to
2ad4f73
Compare
ricardopereira
added a commit
that referenced
this pull request
Feb 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.