Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTP9e #335

Merged
merged 3 commits into from
Apr 5, 2016
Merged

RTP9e #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6688ae
RTP8e
ricardopereira Mar 21, 2016
6e2af82
RTP8e: pending
ricardopereira Mar 21, 2016
8343e4a
Fix RTP9e.
tcard Apr 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Source/ARTAuth.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,10 +336,10 @@ - (NSString *)getClientId {
if ([self.tokenDetails.clientId isEqual:@"*"])
// Any client
return nil;
else
else if (self.tokenDetails.clientId)
return self.tokenDetails.clientId;
}
else if (self.options) {
if (self.options) {
return self.options.clientId;
}
else {
Expand Down
88 changes: 88 additions & 0 deletions Spec/RealtimeClientPresence.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,94 @@ class RealtimeClientPresence: QuickSpec {
}
}


// RTP9
context("update") {

// RTP9e
it("should result in an error immediately if the client is anonymous") {
let client = ARTRealtime(options: AblyTests.commonAppSetup())
defer { client.close() }
let channel = client.channels.get("test")

waitUntil(timeout: testTimeout) { done in
channel.presence.update(nil) { error in
expect(error!.message).to(contain("attempted to publish presence message without clientId"))
done()
}
}
}

// RTP9e
it("should result in an error immediately if the channel is DETACHED") {
let options = AblyTests.commonAppSetup()
options.clientId = "john"
let client = ARTRealtime(options: options)
defer { client.close() }
let channel = client.channels.get("test")

channel.attach()
channel.detach()

waitUntil(timeout: testTimeout) { done in
channel.presence.update(nil) { error in
expect(error!.message).to(contain("invalid channel state"))
done()
}
}
}

// RTP9e
it("should result in an error immediately if the channel is FAILED") {
let options = AblyTests.commonAppSetup()
options.clientId = "john"
let client = ARTRealtime(options: options)
defer { client.close() }
let channel = client.channels.get("test")

channel.onError(AblyTests.newErrorProtocolMessage())

waitUntil(timeout: testTimeout) { done in
channel.presence.update(nil) { error in
expect(error!.message).to(contain("invalid channel state"))
done()
}
}
}

// RTP9e
it("should result in an error if the client does not have required presence permission") {
let options = AblyTests.clientOptions()
options.token = getTestToken(capability: "{ \"cannotpresence:john\":[\"publish\"] }")
options.clientId = "john"
let client = ARTRealtime(options: options)
defer { client.close() }
let channel = client.channels.get("cannotpresence")

waitUntil(timeout: testTimeout) { done in
channel.presence.update(nil) { error in
expect(error!.message).to(contain("Channel denied access based on given capability"))
done()
}
}
}

// RTP9e
it("should result in an error if Ably service determines that the client is unidentified") {
let client = ARTRealtime(options: AblyTests.commonAppSetup())
defer { client.close() }
let channel = client.channels.get("test")

waitUntil(timeout: testTimeout) { done in
channel.presence.update(nil) { error in
expect(error!.message).to(contain("presence message without clientId"))
done()
}
}
}

}

// RTP15e
let cases: [String:(ARTRealtimePresence, Optional<(ARTErrorInfo?)->Void>)->()] = [
"enterClient": { $0.enterClient("john", data: nil, callback: $1) },
Expand Down