Conform to spec changes at ably/docs#112. #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, now timeouts are way simple! Great one. |
| return; | ||
| } | ||
| case ARTRealtimeConnected: | ||
| [_pingEventEmitter timed:[_pingEventEmitter once:cb] deadline:10.0 onTimeout:^{ |
There was a problem hiding this comment.
10s is the default timeout?
There was a problem hiding this comment.
It was hardcoded like that before. Fixed at 0aa8cb6.
|
FYI, I've reviewed ably/docs#112 and had some comments. it is possible that we may need to revisit this after :( |
|
Of course, I counted on that @mattheworiordan, but some parts of this were blocking other things and the refactor was nice anyway. Changing things should be easy now. |
tcard
added a commit
that referenced
this pull request
May 16, 2016
* Add EventEmitter.timed method. * Use EventEmitter instead of manual timers for Realtime timeouts. This should simplify the logic there. * Improve error reporting of Obj-C enum in tests. * Conform to spec changes at ably/docs#112. * Remove outdated test. * Replace hardcoded realtime request timeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required by #385. Note that ably/docs#112 is not merged yet.
Split in several commits for ease of consumption.