Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.1.1 #809

Merged
merged 2 commits into from
Sep 30, 2018
Merged

Release 1.1.1 #809

merged 2 commits into from
Sep 30, 2018

Conversation

ricardopereira
Copy link
Contributor

@ricardopereira ricardopereira commented Sep 29, 2018 •
edited
Loading

Before merging this one, please merge #808 first and then change the base branch of this PR to master.

@ricardopereira
Copy link
Contributor Author

Ups, missing the changelog.

mattheworiordan
mattheworiordan approved these changes Sep 29, 2018
View reviewed changes
Copy link
Member

@mattheworiordan mattheworiordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ricardopereira ricardopereira changed the base branch from update-socketrocket to master September 30, 2018 12:53
@ricardopereira ricardopereira merged commit bf93cf6 into master Sep 30, 2018
@ricardopereira ricardopereira deleted the release-1.1.1 branch September 30, 2018 12:53
@ricardopereira ricardopereira restored the release-1.1.1 branch October 1, 2018 09:38
@ricardopereira ricardopereira deleted the release-1.1.1 branch October 1, 2018 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattheworiordan mattheworiordan mattheworiordan approved these changes

@funkyboy funkyboy Awaiting requested review from funkyboy

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardopereira @mattheworiordan