Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-4748] Adds privacy manifest for iOS plugin #520

Merged
merged 2 commits into from
Apr 17, 2024
Merged

[ECO-4748] Adds privacy manifest for iOS plugin #520

merged 2 commits into from
Apr 17, 2024

Conversation

umair-ably
Copy link
Contributor

  • Includes the same changes from our ably-cocoa repo here
  • Bumps cocoa dependency to v1.2.30

@umair-ably umair-ably requested a review from ttypic April 16, 2024 20:37
@umair-ably umair-ably self-assigned this Apr 16, 2024
@github-actions github-actions bot temporarily deployed to staging/pull/520/features April 16, 2024 20:38 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/520/dartdoc April 16, 2024 20:39 Inactive
Copy link
Contributor

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@umair-ably could you update lock-files for example app and integration test?

cd example/ios
pod update Ably
cd ../../test_integration/ios
pod update Ably

should work

@umair-ably umair-ably merged commit 1d0ef99 into main Apr 17, 2024
8 checks passed
@umair-ably umair-ably deleted the ECO-4748 branch April 17, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants