Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview Release - 1.2.0 preview.1 #89

Merged
merged 5 commits into from
Feb 17, 2021
Merged

Preview Release - 1.2.0 preview.1 #89

merged 5 commits into from
Feb 17, 2021

Conversation

QuintinWillison
Copy link
Contributor

No description provided.

@QuintinWillison QuintinWillison self-assigned this Feb 16, 2021
@QuintinWillison QuintinWillison marked this pull request as draft February 16, 2021 17:22
@QuintinWillison QuintinWillison mentioned this pull request Feb 17, 2021
Merged
@QuintinWillison QuintinWillison changed the base branch from main to feature/rename-package February 17, 2021 10:46
Base automatically changed from feature/rename-package to main February 17, 2021 16:25
@QuintinWillison QuintinWillison marked this pull request as ready for review February 17, 2021 16:27
paddybyers
paddybyers approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@QuintinWillison
Copy link
Contributor Author

Just hit re-run all jobs for third time in a row. These integration tests are not very stable. Each time I run them it's a different runtime that fails. Crossing my fingers that this time'll be lucky.

@QuintinWillison
Copy link
Contributor Author

on this run checks failed for android 24 and 28.
on this run checks failed for android 19.

I'm happy that this indicates test instabilities that we can fix in a subsequent PR, and that these failures shouldn't block the release I am trying to do today.

@QuintinWillison QuintinWillison merged commit 5be7ee8 into main Feb 17, 2021
@QuintinWillison QuintinWillison deleted the release/1.2.0-preview.1 branch February 17, 2021 19:26
@QuintinWillison QuintinWillison mentioned this pull request Feb 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramiro-nd ramiro-nd ramiro-nd approved these changes

@tiholic tiholic tiholic approved these changes

@paddybyers paddybyers paddybyers approved these changes

@kavalerov kavalerov Awaiting requested review from kavalerov

Assignees

@QuintinWillison QuintinWillison

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QuintinWillison @paddybyers @tiholic @ramiro-nd