Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on subpackage #134

Closed
mattheworiordan opened this issue Mar 9, 2020 · 0 comments · Fixed by #136
Closed

Drop dependency on subpackage #134

mattheworiordan opened this issue Mar 9, 2020 · 0 comments · Fixed by #136
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@mattheworiordan
Copy link
Member

See #123 for background.

This from @xshyne88:


@QuintinWillison

I think this needs to be reopened though I think the OP did not mention that this error happens when you have other dependencies such as https://github.com/spf13/viper. (Also seems etcd, and gin-gonic would also be in conflict).

Here is a link to the codec packages solution.
ugorji/go#299

DataDog forked viper and made this exact change in a commit, here is what they did:
DataDog/viper@2922e44

Thanks for taking a look.

@mattheworiordan mattheworiordan added the bug Something isn't working. It's clear that this does need to be fixed. label Mar 9, 2020
lmars added a commit that referenced this issue Mar 9, 2020
Fixes #134.

Signed-off-by: Lewis Marshall <lewis@lmars.net>
paddybyers pushed a commit that referenced this issue Mar 25, 2020
Fixes #134.

Signed-off-by: Lewis Marshall <lewis@lmars.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Development

Successfully merging a pull request may close this issue.

1 participant