Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fromCipherKey does not match spec #492

Closed
tomczoink opened this issue Jul 12, 2019 · 2 comments
Closed

fromCipherKey does not match spec #492

tomczoink opened this issue Jul 12, 2019 · 2 comments
Assignees
@amihaiemil
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@tomczoink
Copy link

In the Java library there's a method fromCipherKey, however according to the spec it should instead be withCipherKey (https://docs.ably.io/client-lib-development-guide/features/#TB3). We should ensure the method matches the spec.
@tomczoink tomczoink added the bug Something isn't working. It's clear that this does need to be fixed. label Jul 12, 2019
@tomczoink tomczoink mentioned this issue Jul 16, 2019
Closed
@paddybyers
Copy link
Member

@amihaiemil are you able to look at this please? Check the spec for exactly what needs to be implemented. If an existing method in the library has the wrong name or signature, then it should be kept but annotated with @deprecated. Tests should exist for both the original and corrected API.

@amihaiemil amihaiemil self-assigned this Nov 1, 2019
amihaiemil added a commit to amihaiemil/ably-java that referenced this issue Nov 1, 2019
@amihaiemil
ably#492 cosmetic changes: moved attributed up + javadocs
dd3bfca
amihaiemil added a commit to amihaiemil/ably-java that referenced this issue Nov 1, 2019
@amihaiemil
ably#492 ChannelOptions.getCipher() made clearer
8ee91a1
amihaiemil added a commit to amihaiemil/ably-java that referenced this issue Nov 1, 2019
@amihaiemil
ably#492 ChannelOptions.withCipherKey + tests
3482631
amihaiemil added a commit to amihaiemil/ably-java that referenced this issue Nov 1, 2019
@amihaiemil
ably#492 braces, formatting, assert messages, variable renaming
d04cc19
@amihaiemil amihaiemil mentioned this issue Nov 1, 2019
Merged
paddybyers pushed a commit that referenced this issue Nov 5, 2019
@amihaiemil @paddybyers
#492 cosmetic changes: moved attributed up + javadocs
491a4d4
paddybyers pushed a commit that referenced this issue Nov 5, 2019
@amihaiemil @paddybyers
#492 ChannelOptions.getCipher() made clearer
ec28feb
paddybyers pushed a commit that referenced this issue Nov 5, 2019
@amihaiemil @paddybyers
#492 ChannelOptions.withCipherKey + tests
76b582d
paddybyers pushed a commit that referenced this issue Nov 5, 2019
@amihaiemil @paddybyers
#492 braces, formatting, assert messages, variable renaming
e874402
@amihaiemil
Copy link
Contributor

@tomczoink PR #513 has been merged. I'm closing this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amihaiemil amihaiemil

Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

No branches or pull requests
3 participants
@paddybyers @amihaiemil @tomczoink