HttpScheduler.AsyncRequest<T> Ignores withCredentials Parameter

[amihaiemil]

The class HttpScheduler.AsyncRequest takes withCredentials boolean flag as constructor parameter, but does nothing with it.

Should we remove it or implement some logic based on it?

[paddybyers]

My memory of this is that I wanted to make a change whereby the credentials were passed down through the Http framework from the caller to the lower layers explicit as credentials arguments, rather than being added to the headers or params. This would allow the credentials to be applied where needed, and would also generalise to handling of proxy credentials as well as the regular endpoint credentials.

However, this work was never completed, and we were left with this vestigial withCredentials argument that's unused.

I think it should be deleted.

[amihaiemil]

@paddybyers ok :) I'll make a PR today