Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid data test #385

Merged
merged 3 commits into from
May 3, 2018
Merged

Fix invalid data test #385

merged 3 commits into from
May 3, 2018

Conversation

funkyboy
Copy link
Contributor

@funkyboy funkyboy commented May 3, 2018

@funkyboy funkyboy requested a review from paddybyers May 3, 2018 08:13
paddybyers
paddybyers reviewed May 3, 2018
View reviewed changes
lib/src/test/java/io/ably/lib/test/realtime/RealtimeMessageTest.java
message.encode(null);

} catch (AblyException e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should also be a catch block for the case that a Throwable is thrown that isn't an AblyException and fail the test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 6999580

paddybyers
paddybyers requested changes May 3, 2018
View reviewed changes
Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but pls add a further catch(Throwable t) { ... }

paddybyers
paddybyers approved these changes May 3, 2018
View reviewed changes
Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@funkyboy funkyboy merged commit a4c33ad into develop May 3, 2018
@funkyboy funkyboy deleted the fix-invalid-data-test branch May 3, 2018 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paddybyers paddybyers paddybyers approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@funkyboy @paddybyers