Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some flaky tests #406

Merged
merged 25 commits into from
Jul 17, 2018
Merged

Fix some flaky tests #406

merged 25 commits into from
Jul 17, 2018

Conversation

funkyboy
Copy link
Contributor

Note: realtime_presence_subscribe_all and realtime_presence_subscribe_multiple failures are related to an issue with realtime. Details here.

funkyboy added 25 commits June 28, 2018 21:09
@funkyboy
Increase timeout interval for RealtimeReauthTest
966b27c
@funkyboy
Remove unneeded wait for close
6273380
@funkyboy
Randomize channel name to avoid clash in channelhistory_types test wi…
0611943 
…th text and binary protocol
@funkyboy
Randomize channel names for channelhistory_time_f test
d9aa7ab
@funkyboy
Temporary ignore channelhistory_time_f test
47c5250
@funkyboy
Tweak values for Rest time tests
d4448c7
@funkyboy
Increase timeout for ConnectionManager tests
65a535c
@funkyboy
Fix typo in assert of reauth_fail test
a8d153c
@funkyboy
Helper now prints the name of the state/event
8059dce
@funkyboy
Add protocol name to channels to avoid possible clashes
e6a8225
@funkyboy
Add catch statement to trap errors in sending presence messages durin…
ecc3203 
…g test
@funkyboy
Collect only enter and update actions in realtime_presence_map_test
219ffb6
@funkyboy
Explicitly fail if there's an exception in publishing history messages
50f9777
@funkyboy
Fix some formatting
d6fe429
@funkyboy
Ignore channelhistory_from_attach due to issues in sandbox
5d43515
@funkyboy
Increase timeout of http_ably_execute_fallback
f100723
@funkyboy
Increase timeout of RealtimeCryptoTest
364f759
@funkyboy
Increase timeout for RealtimeConnectTest
052bd40
@funkyboy
Increase timeout for ConnectionManagerTest
374da68
@funkyboy
Add protocol name to channels to avoid text vs binary clashes
271d2ec
@funkyboy
Explicitly fail presencehistory_from_attach is publisher thread throw…
48d5888 
…s an exception
@funkyboy
Temporarily ignore presencehistory_from_attach test
6229289
@funkyboy
Call presence methods before setting the state of a channel
59f7094
@funkyboy
Add test name to channels to avoid clashing
35fa1c7
@funkyboy
Explicitly wait for failed state in enter/leave presence tests
5b1332e
@funkyboy funkyboy requested a review from paddybyers July 11, 2018 16:22
@funkyboy funkyboy changed the title Fix some flaky tests ci Fix some flaky tests Jul 11, 2018
paddybyers
paddybyers approved these changes Jul 17, 2018
View reviewed changes
Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@paddybyers paddybyers merged commit 560e633 into develop Jul 17, 2018
@KacperKluka KacperKluka deleted the fix-some-flaky-tests-ci branch March 25, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paddybyers paddybyers paddybyers approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@funkyboy @paddybyers