Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetworkConnectivity: ensure all accesses to listeners set are synchronised #469

Merged
merged 1 commit into from
Apr 10, 2019
Merged

NetworkConnectivity: ensure all accesses to listeners set are synchronised #469

merged 1 commit into from
Apr 10, 2019

Conversation

paddybyers
Copy link
Member

Fixes: #468

@paddybyers paddybyers requested a review from amsurana April 10, 2019 16:36
mattheworiordan
mattheworiordan approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@mattheworiordan mattheworiordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM. Seems you're getting used to using single threaded Node too much 😉

@paddybyers paddybyers changed the base branch from release-1.1.0 to develop April 10, 2019 21:25
@paddybyers paddybyers merged commit 389cd1d into develop Apr 10, 2019
@paddybyers paddybyers deleted the concurrent-connectivity-listeners branch April 10, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattheworiordan mattheworiordan mattheworiordan approved these changes

@amsurana amsurana Awaiting requested review from amsurana

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paddybyers @mattheworiordan