Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async callback fix #493

Merged
merged 4 commits into from
Jul 17, 2019
Merged

Async callback fix #493

merged 4 commits into from
Jul 17, 2019

Conversation

amsurana
Copy link
Contributor

callback.onError to be called from Executor during async execution.

@paddybyers paddybyers self-requested a review July 17, 2019 13:03
Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@paddybyers paddybyers merged commit 3070a6c into ably:develop Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants