Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocketTransport: don't null the wsConnection in onClose() #500

Merged
merged 1 commit into from
Oct 17, 2019
Merged

WebSocketTransport: don't null the wsConnection in onClose() #500

merged 1 commit into from
Oct 17, 2019

Conversation

paddybyers
Copy link
Member

Nulling the wsConnection is unnecessary and causes deadlock by reversing lock acquisition order.

Related: #495 (comment)

@paddybyers
WebSocketTransport: don't null the wsConnection in onClose(); this is…
dc3bc3e 
… unnecessary and causes deadlock by reversing lock acquisition order
@paddybyers paddybyers added the bug Something isn't working. It's clear that this does need to be fixed. label Oct 17, 2019
@paddybyers paddybyers merged commit 95e89ca into develop Oct 17, 2019
@KacperKluka KacperKluka deleted the websocket-deadlock-fix branch March 25, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amsurana amsurana

Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paddybyers @amsurana