Update websocket dependency #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed by an auth change is retried immediately
…rate (timer) thread, avoiding deadlock involving the WsClient lock
…n the activity timer is running, since the timer is now also used for WsClient event callbacks
paddybyers
force-pushed
the
update-websocket-dependency
branch
from
e95e5b3 to
d073edb
Compare
amihaiemil
reviewed
Nov 12, 2019
paddybyers
force-pushed
the
update-websocket-dependency
branch
from
a61136a to
d179cfa
Compare
… test interference
… spec items in question
paddybyers
force-pushed
the
update-websocket-dependency
branch
from
dcbae1e to
12ba625
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #503
This updates the
java-websocketdependency to the latest, maintained version, and fixes a few test regressions that surfaced as a result.This also ensures that
WsClientevent callbacks are made into theConnectionManagerwithout holding the internal websocket instance lock, so this should also resolve the issue reported in #495 (comment).