New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix some ConnectionManager tests #526

Merged

QuintinWillison merged 1 commit into ably:develop from amihaiemil:fix_connectionmanager_tests

Dec 10, 2019

Contributor

amihaiemil commented Nov 16, 2019

Fixes #524 ; work in progress.

Changes:

39e69ef
- make all tests throw AblyException to avoid useless try/catch
- make tests use AblyRealtime into try-with-resources so we're sure it's closed at the end (this is except a few tests where the behaviour of ably.close() is part of the test case).
...more to come


          AblyRealtime in try-with-resources and tests throw AblyException

39e69ef

QuintinWillison approved these changes

View reviewed changes

QuintinWillison merged commit 17b52f1 into ably:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet