Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verbose logs in push notification related code #623

Merged
merged 3 commits into from
Nov 20, 2020

Conversation

QuintinWillison
Copy link
Contributor

To assist in debugging an active issue one of our customers is having.

@QuintinWillison QuintinWillison self-assigned this Oct 20, 2020
@QuintinWillison QuintinWillison marked this pull request as ready for review November 19, 2020 11:12
@QuintinWillison
Copy link
Contributor Author

@paddybyers could you please approve this with a view to landing this PR so I can get a 1.2.3 release out to include this additional logging in production. To assist with active customer issue.

FYI, @cruickshankpg 😁

Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@QuintinWillison QuintinWillison merged commit 19649e2 into main Nov 20, 2020
@QuintinWillison QuintinWillison deleted the experimental/push-verbose-logs branch November 20, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants