Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request_id query param if addRequestIds is enabled #678

Merged
merged 7 commits into from
Jul 28, 2021

Conversation

martin-morek
Copy link
Contributor

@martin-morek martin-morek commented Jun 16, 2021

  • Fixes 574
  • Implementation of RSC7c. Adds addRequestIds parameter to client options. If this option is enabled every REST request to Ably should include in a request_id query string parameter a random string obtained by url-safe base64-encoding a sequence of at least 9 bytes obtained from a source of randomness. This request ID must remain the same if a request is retried to a fallback host per RSC15. Any log messages associated with the request should include the request ID. If the request fails, the request ID must be included in the ErrorInfo returned to the user.

@QuintinWillison QuintinWillison marked this pull request as draft June 17, 2021 17:35
@QuintinWillison QuintinWillison changed the title [WIP] Add request_id query param if addRequestIds is enabled Add request_id query param if addRequestIds is enabled Jun 17, 2021
@QuintinWillison QuintinWillison requested review from QuintinWillison and removed request for paddybyers June 24, 2021 08:57
@martin-morek martin-morek marked this pull request as ready for review June 24, 2021 16:03
Copy link
Contributor

@QuintinWillison QuintinWillison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. Just a bit of refactoring please.

@QuintinWillison QuintinWillison merged commit 28d2f81 into main Jul 28, 2021
@QuintinWillison QuintinWillison deleted the 574-RSC7c-addRequestIds-clientOptions branch July 28, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

RSC7c TI1 addRequestIds on ClientOptions and requestId on ErrorInfo
2 participants