Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trying to get property 'items' of non-object #92

Closed
jdavid opened this issue Feb 2, 2021 · 0 comments
Closed

Trying to get property 'items' of non-object #92

jdavid opened this issue Feb 2, 2021 · 0 comments

Comments

@jdavid
Copy link
Contributor

jdavid commented Feb 2, 2021 •
edited by sync-by-unito bot
Loading

While CI is green now I still get many errors locally:

There were 6 errors:

1) tests\AppStatsTest::testAppstatsPagination0
Trying to get property 'items' of non-object

/home/jdavid/sandboxes/Ably/ably-php/tests/AppStatsTest.php:247

2) tests\AppStatsTest::testAppstatsPagination1
Trying to get property 'items' of non-object

/home/jdavid/sandboxes/Ably/ably-php/tests/AppStatsTest.php:273

3) tests\AppStatsTest::testAppstatsPagination2
Trying to get property 'items' of non-object

/home/jdavid/sandboxes/Ably/ably-php/tests/AppStatsTest.php:299

4) tests\AppStatsTest::testAppstatsPagination3
Trying to get property 'items' of non-object

/home/jdavid/sandboxes/Ably/ably-php/tests/AppStatsTest.php:322

5) tests\PresenceTest::testComparePresenceDataWithFixture
Trying to get property 'items' of non-object

/home/jdavid/sandboxes/Ably/ably-php/tests/PresenceTest.php:80

6) tests\PresenceTest::testComparePresenceHistoryWithFixture
Trying to get property 'items' of non-object

/home/jdavid/sandboxes/Ably/ably-php/tests/PresenceTest.php:116

┆Issue is synchronized with this Jira Uncategorised by Unito
jdavid added a commit that referenced this issue Feb 2, 2021
@jdavid
Fix parsePaginationHeaders
2fa3918 
Fixes issue #92

Errors found when running the tests locally:

  1) tests\AppStatsTest::testAppstatsPagination0
  Trying to get property 'items' of non-object

  /home/jdavid/sandboxes/Ably/ably-php/tests/AppStatsTest.php:247

Because for some reason the response headers are lowercase. So match the
"Link" header case insensitive.
@jdavid jdavid mentioned this issue Feb 2, 2021
Merged
@jdavid jdavid closed this as completed Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdavid