Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add case insensitive method to http request #135

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Add case insensitive method to http request #135

merged 1 commit into from
Mar 4, 2022

Conversation

andydunstall
Copy link
Contributor

Adds case insensitivity to the public http request - this came from an issue where they we're using a lowercase method:

$client = new Ably\AblyRest('...');
$resp = $client->request('get', '/time', [], '', []);
echo $resp->statusCode; // 400

so the curl options never seemed to get set - so returned 400

@andydunstall andydunstall requested a review from owenpearson March 4, 2022 08:22
owenpearson
owenpearson approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@owenpearson owenpearson merged commit 80c9f87 into main Mar 4, 2022
@owenpearson owenpearson deleted the case-insensitive-method branch March 4, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuintinWillison QuintinWillison QuintinWillison approved these changes

@owenpearson owenpearson owenpearson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andydunstall @QuintinWillison @owenpearson