-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MsgPack #161
Conversation
Looks good for now, but you will need to update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As previously stated, update .github/workflows/check.yml
to run tests for binary protocol version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work 🙂
Couple of formatting fixes to be made, my main comment however is that according to RSC8a msgpack should be the default as long as PHP as a platform has sufficient support for it. I haven't looked at rybakit/msgpack but are you able to comment on whether it should work fine for any PHP application (ie does it require any system dependencies that weren't already required by ably-php)? If it's not gonna be a breaking change then I think we should change the default useBinaryProtocol
client option to true
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good after the changes to make MsgPack the default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks 👍
Other than few changes, looks good to me overall 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
I had to alter a few tests that included base64 decode, since with messagepack, binary data is sent as bytes, without the need to specify the base64 encoding.