Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V0.8 spec update #18

Merged
merged 18 commits into from
Dec 15, 2015
Merged

V0.8 spec update #18

merged 18 commits into from
Dec 15, 2015

Conversation

bladeSk
Copy link
Contributor

@bladeSk bladeSk commented Nov 11, 2015

Mostly changes related to handling clientId and proper parameter overriding when generating tokens, with tests.

@bladeSk
Added wildcard ('*') clientId support
c71ef13 
Test for wildcard being rejected in ClientOptions
Tests for authParams and tokenParams overriding in Auth
@bladeSk
Merge remote-tracking branch 'upstream/master'
859d216
@bladeSk
Tests for Auth::getClientId behavior
3d4fd8a 
Fixed AuthTest suite failing to run
@bladeSk
Added support for additional clientId parameter to Channel::publish()…
eb9c477 
… + test

Added test for checking that explicit clientId on both published message and library instance works
Minor code clean up
@bladeSk
Improved requestToken() edge case ($tokenParams->clientId === null) h…
87354ab 
…andling

Updated type tests
Added test suite for spec  Auth/clientId edge cases (RSA8f)
@mattheworiordan
Copy link
Member

Looks good, 👍

bladeSk added 13 commits December 3, 2015 11:21
@bladeSk
Fixed parameter order for Auth::requestToken and Auth::authorise
f1d872a
@bladeSk
Fixed parameter order in Auth::createTokenRequest
702fd65
@bladeSk
A version header automatically added to every HTTP request + test
3ed5803 
Added a framework to test the Http class and a new test suite for it
@bladeSk
Updated models to reflect the latest spec changes in ClientOptions
949ae35 
Auth now uses defaultTokenParams
Created type test for AuthOptions
@bladeSk
Fixed all discrepancies related to handling of clientId
8dde0e0 
Moved all clientId related tests to ClientIdTest test suite
@bladeSk
PHP7 strict mode fixes and bug fixes in CurlWrapper.php
08a68a7
@bladeSk
Updated testClientIdLib to verify automatic switching to token auth
34e1ab3
@bladeSk
Auth::authorise now stores provided parameters as defaults + test
1cf1d74
@bladeSk
Added support for connection timeout and fallback max retry count
449cf10
@bladeSk
Allow mocking of Auth, added test to verfiy (RSA10e)
74316a4
@bladeSk
Fixed parameter overriding in Auth::createTokenRequest()
922363d 
Changed tests in AuthTest to verify requestToken() instead of authorise()
Added more tests for createTokenRequest()
Cleaned up AuthTest test suite
@bladeSk
Added tests for authorise() parameters
ac97e4c
@bladeSk
Changed Auth::getClientId() to magic property Auth::clientId
25cef0c
bladeSk added a commit that referenced this pull request Dec 15, 2015
@bladeSk
Merge pull request #18 from bladeSk/master
b0e70f2 
V0.8 spec update
@bladeSk bladeSk merged commit b0e70f2 into ably:master Dec 15, 2015
@charles85 charles85 mentioned this pull request Jan 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bladeSk @mattheworiordan