Moved force parameter out of authorise() to AuthOptions
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions, changed method calls in tests and library. TokenParams.timestamp and AuthOptions.force don't get remembered by authorise() + test
| } | ||
| if ( !empty( $authOptions ) ) { | ||
| $this->defaultAuthoriseAuthOptions = array_merge( $this->defaultAuthoriseAuthOptions, $authOptions ); | ||
| $authOptionsCopy = $authOptions; |
There was a problem hiding this comment.
I am not that fimiliar with PHP, but would this line simply create a new reference as opposed to create a duplicate of the associative array? If so, that would mean that the following line unset( $authOptionsCopy['force'] ) would in fact remove force from both.
There was a problem hiding this comment.
In fact, no. PHP is totally backwards and arrays (but not objects!) are copied by value http://stackoverflow.com/a/1533214/388994 Hence the name authOptionsCopy.
There was a problem hiding this comment.
Ok, very backwards, I saw the name but expected that was a bug, hence the question. Thanks for clarifying.
|
Looks good, interested to get your thoughts on my comment though before merging |
mattheworiordan
added a commit
that referenced
this pull request
Jan 14, 2016
Moved `force` parameter out of authorise() to AuthOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #23