0.9 compatibility - version HTTP headers, fallbackHosts, request() and decoding interop. test #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st method to requestInternal
| @@ -117,7 +119,7 @@ public function request( $method, $url, $headers = array(), $params = array() ) | |||
| $this->curl->setOpt( $ch, CURLOPT_POSTFIELDS, $params ); | |||
|
|
|||
| if ($this->postDataFormat == 'json') { | |||
| array_push( $headers, 'Accept: application/json', 'Content-Type: application/json' ); | |||
| array_push( $headers, 'Content-Type: application/json' ); | |||
There was a problem hiding this comment.
Out of interest, why did you remove the Accept header. We default to JSON in our response, but isn't it better to be explicit?
There was a problem hiding this comment.
The accept header was sent only when there were either GET parameters or POST body set. This was a wrong place to set the header. It should be probably sent in all the requests, I'll fix that.
|
Looks good, but unfortunately the interoperability test is not doing enough. See ably/docs#146 as well |
|
Nice work @bladeSk, that looks great :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.