Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSH1b2 New push.admin.device_registrations.list_ #68

Merged
merged 1 commit into from
Feb 11, 2019
Merged

RSH1b2 New push.admin.device_registrations.list_ #68

merged 1 commit into from
Feb 11, 2019

Conversation

jdavid
Copy link
Contributor

@jdavid jdavid commented Feb 8, 2019

list is a reserved word, so we use list_

list is a reserved word, so we use list_
Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but as mentioned can we add a test please that the pagination works?

@paddybyers
Copy link
Member

From Slack:

actually it doesn't work, next()
the server returns Link: <./push/deviceRegistrations?limit=1&format=json&offset=0%3A0%3AZmFhNWNjZTM3YmEwYjg0ODlhZGMwMzVmMDc%3D>; rel="next"
then ./push/deviceRegistrations?limit=1&format=json&offset=0%3A0%3AZmFhNWNjZTM3YmEwYjg0ODlhZGMwMzVmMDc%3D is resolved against /push/deviceRegistrations
returning /push/push/deviceRegistrations?limit=1&format=json&offset=0%3A0%3AZmFhNWNjZTM3YmEwYjg0ODlhZGMwMzVmMDc%3D
what produces a 404 error
@paddy should I interpret the ./push/deviceRegistrations?limit=1&format=json&offset=0%3A0%3AZmFhNWNjZTM3YmEwYjg0ODlhZGMwMzVmMDc%3D as if it was an absolute path?
the code is like that since 2015,

paddy [9:43 AM]
@jdavid no, that's a bug. The rel link should be './deviceRegistrations?....

@paddybyers
Copy link
Member

@jdavid I think this should be merged, and additional pagination tests added as a separate PR once the realtime issue is resolved.

@jdavid jdavid merged commit ce38290 into push Feb 11, 2019
@jdavid jdavid deleted the RSH1b2 branch February 11, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants