Complete functionality #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auth exceptions + tests
Fallback hosts are randomized Updated fallback host tests and fixed test not using tls
Updated ChannelHistory test suite to test pagination, sped up slow tests Updated pagination method names to match Java lib Removed useless/unused methods to improve coverage + fixed tests being covered
|
Here's a coverage report for the current version: http://dev.blade.sk/ably/ |
| @@ -63,7 +64,7 @@ public function channel( $name, $options = array() ) { | |||
| * @return array Statistics | |||
| */ | |||
| public function stats( $params = array() ) { | |||
| return $this->get( '/stats', $headers = array(), $params ); | |||
| return new PaginatedResource( $this, 'Ably\Models\Stats', $cipher = false, '/stats', $params ); | |||
There was a problem hiding this comment.
Don't let this effect this PR, but can you add an issue to change this to PaginatedResult for consistency, see ably/ably-ruby#40
|
Awesome PR @bladeSk, 🚀 👍 |
| @@ -81,10 +81,17 @@ public function getFirst() { | |||
| } | |||
|
|
|||
| /** | |||
| * @return boolean Whether there is a next page | |||
There was a problem hiding this comment.
Whether there is a first page
|
Yep looks good to me too. 👍 |
…ing composer, added license
…e when making requests)
Updated readme
…lid auth params, environment support in ClientOptions, removed unnecessary request to /time on each authorized request Added Auth tests, AblyRest tests, Stats tests
Added useTokenAuth to AuthOptions Support for authUrl returning token string Fixed wrong params of authorise() Fixed wrong params handling of createTokenRequest()
Bug fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the major features from http://docs.ably.io/client-lib-development-guide/features/#rest should be in place (except for msgPack, which doesn't have any stable PHP library at the moment).